Allow omission of attributes if attributeOldValue or attributeFilter is present#12
Open
thompsongl wants to merge 1 commit intowebmodules:masterfrom
Open
Allow omission of attributes if attributeOldValue or attributeFilter is present#12thompsongl wants to merge 1 commit intowebmodules:masterfrom
attributes if attributeOldValue or attributeFilter is present#12thompsongl wants to merge 1 commit intowebmodules:masterfrom
Conversation
Author
|
Circling back to this to say that the above is only valid if IE11 support is not of concern. The polyfill appears to implement an old(?) version of the spec in which |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the whatwg standard,
attributeshas no default value inMutationObserverInit(i.e., notfalse).Also,
attributesshould be set totrueif implicitlytrue(i.e.,attributeOldValueorattributeFilteris specified).This PR will allow the omission of the
attributesoption ifattributeOldValueorattributeFilteris specified.Depending on your setup, you can work around this in the meantime by patching the
observemethod:(h/t @chandlerprall)